Various minor improvements to unit tests for package index projects #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

per1234 merged 3 commits into arduino:main from per1234:fix-tests

Jun 14, 2021

Merged

Various minor improvements to unit tests for package index projects #190

per1234 merged 3 commits into arduino:main from per1234:fix-tests

Jun 14, 2021

Conversation

per1234

Copy link

Contributor

@per1234 per1234 commented Jun 14, 2021

Use more appropriate packager name in test data package indexes
Add test messages to all package index project data tests
Correct order of arguments in test equality assertions

per1234 added 3 commits

June 11, 2021 14:40

@per1234


 Use more appropriate packager name in test data package indexes

21f1c9f

The previous "myboard" packager name was inherited from the sample package index in the specification, but it is not a
very intuitive packager name so it might cause confusion.

@per1234


 Add test messages to all package index project data tests

80c12cb

This makes it possible to identify which test table item a test failure was associated with.

@per1234


 Correct order of arguments in test equality assertions

e8043e1

The order of the arguments is expected, actual. I had it backwards, resulting in very confusing test failure messages.

@per1234 per1234 added type: bug type: enhancement topic: infrastructure labels

Jun 14, 2021

@per1234 per1234 requested review from silvanocerza and umbynos

June 14, 2021 03:28

@codecov-commenter

Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #190 (e8043e1) into main (3d2ae4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #190 +/- ##
=======================================
 Coverage 84.03% 84.03% 
=======================================
 Files 43 43 
 Lines 3201 3201 
=======================================
 Hits 2690 2690 
 Misses 396 396 
 Partials 115 115

Flag	Coverage Δ
unit	`84.03% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2ae4c...e8043e1. Read the comment docs.