Use most appropriate function for checking URL #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

per1234 merged 1 commit into arduino:main from per1234:fix-url-check

Jun 7, 2021

Merged

Use most appropriate function for checking URL #185

per1234 merged 1 commit into arduino:main from per1234:fix-url-check

Jun 7, 2021

Conversation

per1234

Copy link

Contributor

@per1234 per1234 commented Jun 7, 2021 •

edited

Loading

From the http.Get() documentation:

Caller should close resp.Body when done reading from it.

This was not done previously. Since the body is not needed, http.Head() is more appropriate for this application and it
does not impose the requirement to add additional code to clean up.

@per1234


 Use most appropriate function for checking URL

3adc412

From the http.Get() documentation:
> Caller should close resp.Body when done reading from it.
This was not done previously. Since the body is not needed, http.Head() is more appropriate for this application and it
does not impose the requirement to add additional code to clean up.

@per1234 per1234 added type: bug topic: code labels

Jun 7, 2021

@per1234 per1234 requested review from silvanocerza and umbynos

June 7, 2021 08:45

@codecov-commenter

Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #185 (3adc412) into main (539e940) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## main #185 +/- ##
=======================================
 Coverage 84.37% 84.37% 
=======================================
 Files 43 43 
 Lines 3078 3078 
=======================================
 Hits 2597 2597 
 Misses 381 381 
 Partials 100 100

Flag	Coverage Δ
unit	`84.37% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/rule/rulefunction/library.go	`94.79% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539e940...3adc412. Read the comment docs.