Add rules for checking package index filename #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

per1234 merged 1 commit into arduino:main from per1234:package-index-filename-rules

Jun 7, 2021

Merged

Add rules for checking package index filename #184

per1234 merged 1 commit into arduino:main from per1234:package-index-filename-rules

Jun 7, 2021

Conversation

per1234

Copy link

Contributor

@per1234 per1234 commented Jun 6, 2021

The package index filename must follow a specific format. Package indexes which are not compliant are ignored by the
Arduino development software.

Only the official package index may be named package_index.json.

@per1234


 Add rules for checking package index filename

b24f9e2

The package index filename must follow a specific format. Package indexes which are not compliant are ignored by the
Arduino development software.
Only the official package index may be named package_index.json.

@per1234 per1234 added type: enhancement topic: code labels

Jun 6, 2021

@per1234 per1234 requested review from cmaglie and umbynos

June 6, 2021 22:44

@codecov-commenter

Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

Merging #184 (b24f9e2) into main (53c1162) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 84.45% 84.50% +0.05% 
==========================================
 Files 43 43 
 Lines 3017 3027 +10 
==========================================
+ Hits 2548 2558 +10 
 Misses 375 375 
 Partials 94 94

Flag	Coverage Δ
unit	`84.50% <100.00%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ternal/rule/ruleconfiguration/ruleconfiguration.go	`100.00% <ø> (ø)`
internal/rule/rulefunction/packageindex.go	`82.60% <100.00%> (+13.37%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c1162...b24f9e2. Read the comment docs.