-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add new mbed architecture variants to rules #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
May 12, 2021
Codecov Report
@@ Coverage Diff @@ ## main #171 +/- ## ========================================== + Coverage 84.32% 84.34% +0.02% ========================================== Files 43 43 Lines 2966 2970 +4 ========================================== + Hits 2501 2505 +4 Misses 373 373 Partials 92 92
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
silvanocerza
silvanocerza
approved these changes
May 12, 2021
Rules LP045 and LP046 utilize a lists of standardized architecture names. In the recent 2.0.0 release of the Arduino Mbed OS Boards platform, the `mbed` architecture was split into four variants: - mbed_edge (Arduino Edge Control) - mbed_nano (Arduino Nano 33 BLE, Arduino RP2040 Connect) - mbed_portenta (Arduino Portenta H7) - mbed_rp2040 (Raspberry Pi Pico and other 3rd party RP2040 boards) So the architecture lists used in the rules should be updated accordingly.
umbynos
umbynos
reviewed
May 12, 2021
umbynos
umbynos
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules
LP045andLP046utilize a lists of standardized architecture names. In the recent 2.0.0 release of the Arduino MbedOS Boards platform, the
mbedarchitecture was split into four variants:mbed_edge(Arduino Edge Control)mbed_nano(Arduino Nano 33 BLE, Arduino RP2040 Connect)mbed_portenta(Arduino Portenta H7)mbed_rp2040(Raspberry Pi Pico and other 3rd party RP2040 boards)So the architecture lists used in the rules should be updated accordingly.