Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[skip changelog] Update create changelog action #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silvanocerza merged 1 commit into main from scerza/update-create-changelog-action
Jan 7, 2021

Conversation

Copy link
Contributor

@silvanocerza silvanocerza commented Jan 4, 2021

The create-changelog action has been updated to support case insensitive regexes, the filter-regex property has been updated accordingly.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran the workflow it had an error:
https://github.com/per1234/arduino-lint/runs/1648142960?check_suite_focus=true#step:3:15

Error: Invalid flags supplied to RegExp constructor 'true'

Copy link
Contributor Author

When I ran the workflow it had an error:
https://github.com/per1234/arduino-lint/runs/1648142960?check_suite_focus=true#step:3:15

Error: Invalid flags supplied to RegExp constructor 'true'

I realize now that I made a mistake in the create-changelog action. 🤦
Will fix it and update the PR.

@silvanocerza silvanocerza force-pushed the scerza/update-create-changelog-action branch from 893e4d8 to ef54daa Compare January 5, 2021 10:00
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the release workflow in my fork and it worked perfectly. Thanks!

@silvanocerza silvanocerza merged commit 0de21f6 into main Jan 7, 2021
@silvanocerza silvanocerza deleted the scerza/update-create-changelog-action branch January 7, 2021 09:27
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /