Don't HTML-sanitize JSON output #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

per1234 merged 1 commit into main from per1234/remove-report-html-encoding

Dec 27, 2020

Merged

Don't HTML-sanitize JSON output #135

per1234 merged 1 commit into main from per1234/remove-report-html-encoding

Dec 27, 2020

Conversation

per1234

Copy link

Contributor

@per1234 per1234 commented Dec 23, 2020

By default, the json package HTML-sanitizes strings during marshalling. This is not useful for this application and resulted in the JSON output containing gibberish.

Before:

"rules": [
 {
 "category": "library.properties",
 "subcategory": "author field",
 "ID": "LP024",
 "brief": "author \u003c min length",
 "description": "",
 "result": "fail",
 "level": "error",
 "message": "library.properties author value is less than minimum length."
 },

After:

"rules": [
 {
 "category": "library.properties",
 "subcategory": "author field",
 "ID": "LP024",
 "brief": "author < min length",
 "description": "",
 "result": "fail",
 "level": "error",
 "message": "library.properties author value is less than minimum length."
 }

@per1234


 Don't HTML-sanitize JSON output

155947e

By default, the `json` package HTML-sanitizes strings during marshalling. This is not useful for this application and
resulted in the JSON output containing gibberish.

@per1234 per1234 requested a review from ubidefeo

December 23, 2020 07:43

ubidefeo

ubidefeo approved these changes

Dec 27, 2020

View reviewed changes