-
-
Notifications
You must be signed in to change notification settings - Fork 12
Make all packages internal #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure of the "Lint configuration files" workflow is expected and unrelated to the changes proposed in this PR. It will be fixed by #114
silvanocerza
silvanocerza
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, good idea.
@per1234
per1234
force-pushed
the
per1234/internal
branch
from
December 20, 2020 05:37
d521678 to
6a1eba3
Compare
The Go packages of this project were written solely for the use within the project. Making them internal avoids them unintentionally becoming part of the public API, resulting in a greatly increased potential maintenance and support burden and limitations on further development work. It would be interesting to identify the components of the internal API that might be useful to others and expose them intentionally as they reach a state of relative stability. However, for now the public API should be considered only the command line interface and the JSON report structure.
@per1234
per1234
force-pushed
the
per1234/internal
branch
from
December 20, 2020 06:06
6a1eba3 to
d521897
Compare
@per1234
per1234
added
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
labels
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go packages of this project were written solely for the use within the project. Making them internal avoids them
unintentionally becoming part of the public API, resulting in a greatly increased maintenance and support burden and
limitations on further development work.
It would be interesting to identify the components of the internal API that might be useful to others and expose them intentionally as they reach a state of relative stability. However, for now the API should be considered only the command line interface and the JSON report structure.