-
-
Notifications
You must be signed in to change notification settings - Fork 12
Embed JSON schemas in code #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
silvanocerza
approved these changes
Dec 14, 2020
silvanocerza
silvanocerza
approved these changes
Dec 14, 2020
Previously, the schemas were provided as external files. This presented some difficulties for testing and was also likely to make distribution and installation more complex. By embedding the schemas as binary data in the Go code, the tool can consist of a single standalone binary.
The previous `go fmt` command was not formatting the code under the testdata folder.
The stringer tool is used to generate stringers for the "enums".
@per1234
per1234
force-pushed
the
per1234/embed-schemas
branch
from
December 14, 2020 14:42
9f86398 to
3aa02c7
Compare
Merged
@per1234
per1234
added
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
labels
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the JSON schemas were provided as external files. This presented some difficulties for testing and was also
likely to make distribution and installation more complex.
By embedding the schemas as binary data in the Go code, the
tool can consist of a single standalone binary.
Fixes #95 (Thanks Silvano!)