-
-
Notifications
You must be signed in to change notification settings - Fork 18
Fixed the S3 upload for the nightlies #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsora
rsora
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
I was expecting the build to start for PRs, I am looking into it.
@kittaakos
kittaakos
force-pushed
the
fix-action-for-s3-upload
branch
2 times, most recently
from
August 24, 2020 12:37
1bb5807 to
27c75b6
Compare
I am looking into it.
It's fixed now.
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos
kittaakos
force-pushed
the
fix-action-for-s3-upload
branch
from
August 24, 2020 15:27
b43cf1b to
121f27c
Compare
@kittaakos
kittaakos
changed the title
(削除) Use the original action for S3 upload. (削除ここまで)
(追記) Fixed the S3 upload for the nightlies (追記ここまで)
Aug 24, 2020
@per1234, I have updated the title, description, and workflow config. Please review.
per1234
per1234
reviewed
Aug 24, 2020
Made the S3 'publish' job dependent on the 'build' jobs. From now on, the upload happens when the build was green on each platform. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos
kittaakos
force-pushed
the
fix-action-for-s3-upload
branch
from
August 24, 2020 16:41
121f27c to
5b9966f
Compare
per1234
per1234
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What it does:
'kittaakos/upload-s3-action'GH Action to'docker://plugins/s3'. The main reasons not using the original'shallwefootball/upload-s3-action'action are the followings:'docker://plugins/s3'action is streamlined with the CLI,'https://github.com/shallwefootball/upload-s3-action/'has issues.As for the CI verification:
Signed-off-by: Akos Kitta kittaakos@typefox.io