-
-
Notifications
You must be signed in to change notification settings - Fork 18
Bump actions/setup-go from 5 to 6 #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this causes a regression:
Modernize usages of outdated APIs
Run task go:fix
task go:fix
shell: /usr/bin/bash -e {0}
env:
GO_VERSION: 1.22.0
GOTOOLCHAIN: local
GO_MODULE_PATH: ./
task: [go:fix] go fix github.com/arduino/arduino-language-server github.com/arduino/arduino-language-server/globals github.com/arduino/arduino-language-server/ls github.com/arduino/arduino-language-server/sourcemapper github.com/arduino/arduino-language-server/streams github.com/arduino/arduino-language-server/version
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
task: Failed to run task "go:fix": exit status 1
The fault does not occur in the workflow runs using actions/setup-go@v5.
I notice that the GOTOOLCHAIN environment variable is not defined by that version of the action:
https://github.com/arduino/arduino-language-server/actions/runs/17485157349/job/49662673720#step:5:1
Modernize usages of outdated APIs
Run task go:fix
task go:fix
shell: /usr/bin/bash -e {0}
env:
GO_VERSION: 1.22.0
GO_MODULE_PATH: ./
task: [go:fix] go fix github.com/arduino/arduino-language-server github.com/arduino/arduino-language-server/globals github.com/arduino/arduino-language-server/ls github.com/arduino/arduino-language-server/sourcemapper github.com/arduino/arduino-language-server/streams github.com/arduino/arduino-language-server/version
So I'll put this on hold for now. Hopefully a fix will be made in the actions/setup-go action. Otherwise we'll need to make time to investigate and find a fix (perhaps working around it by bumping the project Go version?).
Bumps actions/setup-go from 5 to 6.
Release notes
Sourced from actions/setup-go's releases.
... (truncated)
Commits
4469467Bump actions/checkout from 4 to 5 (#631)e093d1eNode 24 upgrade (#624)1d76b95Improve toolchain handling (#460)e75c3e8Bumpform-datato bring in fix for critical vulnerability (#618)8e57b58Bump eslint-plugin-jest from 28.11.0 to 29.0.1 (#603)7c0b336Bump typescript from 5.4.2 to 5.8.3 (#538)6f26dccBump undici from 5.28.5 to 5.29.0 (#594)8d4083aBump@typescript-eslint/parserfrom 5.62.0 to 8.32.0 (#590)fa96338Bump@actions/tool-cachefrom 2.0.1 to 2.0.2 (#591)4de67c0Bump@types/jestfrom 29.5.12 to 29.5.14 (#589)Dependabot compatibility score
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)