-
-
Notifications
You must be signed in to change notification settings - Fork 18
Fix panic in extractDataFolderFromArduinoCLI #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When using the latest arduino CLI (nightly-20240102 Commit: db53f81) the
return of `arduino-cli config dump` looks like:
{
"config": {
"directories": {
"data": "/home/nicolas/.arduino15",
"downloads": "/home/nicolas/.arduino15/staging",
"user": "/home/nicolas/Arduino"
}
}
}
CLA assistant check
All committers have signed the CLA.
Please consider adding to the CLA a clause like in Signal's one that explicitly says the contribution will always be available under an open-source license:
- Grant of Copyright License. Subject to the terms and conditions of this Agreement, You hereby grant to Open Whisper Systems and to recipients of software distributed by Signal Messenger a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute Your Contributions and such derivative works, as well as the right to sublicense and have sublicensed all of the foregoing rights, through multiple tiers of sublicensees, provided that in all cases, Signal Messenger will make Your Contributions available under an OSI-approved open source license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch! 👍🏼
Please consider adding to the CLA a clause like in Signal's one that explicitly says the contribution will always be available under an open-source license:
AFAIU this should already be true because a hypothetical license change is not retroactive. If Arduino decides to do a license change at time T, the code already released before T will keep the existing license. At least this is my interpretation, but I don't see how it could be otherwise. :-)
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
before creating one)
Fix a panic when starting the server with a recent version of arduino-cli.
The server panics:
The server runs nicely.
When using the latest arduino CLI (nightly-20240102 Commit: db53f81) the
return of
arduino-cli config dumplooks like:Related to arduino/arduino-cli#2407