Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Can build the IDE on macOS 13.2 (Monterey). #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kittaakos wants to merge 1 commit into arduino:main from kittaakos:fix-build-macos-12_3

Conversation

Copy link
Contributor

@kittaakos kittaakos commented May 15, 2022

Motivation

Updated electron-builder version to build the IDE on macOS 13.2 (Monterey).

/usr/bin/python was hard-coded in the builder. 23.0.2 can handle missing python2 on macOS.

Upstream ref: electron-userland/electron-builder#6789

Before:

⏱️ >>> Packaging your Arduino IDE application...
$ cross-env DEBUG=* && electron-builder --publish=never
 • electron-builder version=22.10.5 os=21.4.0
 • loaded configuration file=package.json ("build" field)
 • skipped dependencies rebuild reason=npmRebuild is set to false
 • packaging platform=darwin arch=x64 electron=15.3.6 appOutDir=dist/mac
 • Unpacking electron zip zipPath=undefined
 • asar usage is disabled — this is strongly not recommended solution=enable asar and use asarUnpack to unpack files that must be externally available
 • asar usage is disabled — this is strongly not recommended solution=enable asar and use asarUnpack to unpack files that must be externally available
 • skipped macOS application code signing reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, see https://electron.build/code-signing allIdentities=
 0 identities found
 
 Valid identities only
 0 valid identities found
Skipping notarization: not on CI.
 • building target=macOS zip arch=x64 file=dist/arduino-ide_2.0.0-rc6-snapshot-b407d0a_macOS_64bit.zip
 • building target=DMG arch=x64 file=dist/arduino-ide_2.0.0-rc6-snapshot-b407d0a_macOS_64bit.dmg
 • building embedded block map file=dist/arduino-ide_2.0.0-rc6-snapshot-b407d0a_macOS_64bit.zip
 ⨯ Exit code: ENOENT. spawn /usr/bin/python ENOENT stackTrace=
 Error: Exit code: ENOENT. spawn /usr/bin/python ENOENT
 at /Users/a.kitta/Desktop/arduino-ide/electron/build/node_modules/builder-util/src/util.ts:129:16
 at exithandler (child_process.js:390:5)
 at ChildProcess.errorhandler (child_process.js:402:5)
 at ChildProcess.emit (events.js:400:28)
 at Process.ChildProcess._handle.onexit (internal/child_process.js:280:12)
 at onErrorNT (internal/child_process.js:469:16)
 at processTicksAndRejections (internal/process/task_queues.js:82:21)

After:

⏱️ >>> Packaging your Arduino IDE application...
$ cross-env DEBUG=* && electron-builder --publish=never
 • electron-builder version=23.0.2 os=21.4.0
 • loaded configuration file=package.json ("build" field)
 • skipped dependencies rebuild reason=npmRebuild is set to false
 • packaging platform=darwin arch=x64 electron=15.3.6 appOutDir=dist/mac
 • asar usage is disabled — this is strongly not recommended solution=enable asar and use asarUnpack to unpack files that must be externally available
 • asar usage is disabled — this is strongly not recommended solution=enable asar and use asarUnpack to unpack files that must be externally available
 • skipped macOS application code signing reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible, see https://electron.build/code-signing allIdentities= 0 identities found
 Valid identities only
 0 valid identities found
Skipping notarization: not on CI.
 • building target=macOS zip arch=x64 file=dist/arduino-ide_2.0.0-rc6-snapshot-bbf829b_macOS_64bit.zip
 • building target=DMG arch=x64 file=dist/arduino-ide_2.0.0-rc6-snapshot-bbf829b_macOS_64bit.dmg
 • building block map blockMapFile=dist/arduino-ide_2.0.0-rc6-snapshot-bbf829b_macOS_64bit.dmg.blockmap
 • building block map blockMapFile=dist/arduino-ide_2.0.0-rc6-snapshot-bbf829b_macOS_64bit.zip.blockmap
👌 <<< Packaging your Arduino IDE application.
🎉 Success. Your application is at: /Users/a.kitta/Desktop/arduino-ide/electron/build/dist
✨ Done in 356.61s.

Change description

Updated the electron-builder dependency.

Other information

The version change was in a "template" package.json file. I do not know if snyk.io checks this.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)
 

`python2` was hard-coded in the builder. `23.0.2` can handle it.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added the topic: code Related to content of the project itself label May 15, 2022
@per1234 per1234 added the os: macos Specific to macOS operating system label May 15, 2022
Copy link
Contributor Author

It was part of #947. Closing.

@per1234 per1234 added the conclusion: duplicate Has already been submitted label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted os: macos Specific to macOS operating system topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /