-
-
Notifications
You must be signed in to change notification settings - Fork 489
add notes for Windows contributor in BUILDING.md #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstasi
fstasi
suggested changes
Mar 22, 2022
per1234
per1234
requested changes
Mar 23, 2022
@per1234
per1234
added
topic: documentation
Related to documentation for the project
type: enhancement
Proposed improvement
labels
Mar 23, 2022
Co-authored-by: per1234 <accounts@perglass.com>
per1234
per1234
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @francescospissu!
fstasi
fstasi
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To build arduino-ide locally on Windows you need to install the Microsoft Visual C++ compiler toolset.
Change description
Added a note for Windows contributors on BUILDING.md file for installing the C++ compiler toolset
Reviewer checklist