-
-
Notifications
You must be signed in to change notification settings - Fork 490
#919, #881: Fixed 3rd party URLs-related issues #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @kittaakos for contributing, works like a charm to me.
@per1234 do you want to give this PR a try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The File > Preferences > Additional Boards Manager URLs field no longer allows me to type a comma at the end of the line. This is problematic because it is a comma-separated list so a user who wants to add multiple URLs directly via the field will expect to be able to add a URL, then a comma, then the next URL.
- Select File > Preferences... from the Arduino IDE menus.
- Type a URL into the "Additional Boards Manager URLs" field.
- Type
,
🐛 The expected , character is not added. If you don't notice then the next URL will not be separated from the previous one.
It does allow commas to be added within existing text. It is only ignored when adding one at the end of the line.
ubidefeo
commented
Mar 24, 2022
@kittaakos please address changes requested by @per1234 so I can approve this
Thanks for the note. I did not forget about this. I will try to find some time to update the PR this week, @ubidefeo. The bug reported by Per is valid. I most likely need to change the <input> from a controlled React component to an uncontrolled one. To sum up, the fix is slightly bigger than I have expected.
dd360f3 to
073190e
Compare
Closes arduino#919. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
Closes arduino#881. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
073190e to
51aef8a
Compare
I have updated this PR. This time, I spent more time verifying my changes locally. Hopefully, I did not overlook anything and fixed the issue. Please review. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working perfectly for me now. Thanks Akos!
Uh oh!
There was an error while loading. Please reload this page.
Motivation
This PR fixes various 3rd party URLs issues:
inputgenerates incorrectboard_manager#additional_urlsentry in the CLI config #919 ),textareaheight (Incorrect "Additional Boards Manager URLs" dialog field height #881 )Change description
displayto fix thetextareaheight in the 3rd party URLs selector dialog.Before:
Screen Shot 2022年03月17日 at 14 18 00
After:
Screen Shot 2022年03月17日 at 14 17 47
Other information
I am happy to split the PR into two, however, I thought it's easier to verify the 3rd party URLs changes in one shot. Let me know if a PR split is desired.
I do not know what this means. Thanks!
Reviewer checklist