-
-
Notifications
You must be signed in to change notification settings - Fork 491
Improve condition to recognise read-only sketches #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@AlbyIanna does this fix the following?
Yes it fixes #917.
As per #866, no, this PR only concerns read-only files that cannot be edited, and not read-only files that cannot be closed. Anyway, I believe #866 has already been fixed in another PR.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ede63f6 to
c0c257e
Compare
arduino-ide-extension/src/common/protocol/sketches-service-client-impl.ts
Outdated
Show resolved
Hide resolved
c0c257e to
180b0fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected for me now.
Thanks @AlbyIanna!
Motivation
The condition to check if a sketch must be shown in read-only mode is too mild. For example, a
thingProperties.hfile shouldn't be read-only if it's not inside an IoT sketchChange description
Check if it's an IoT sketch.
Reviewer checklist