-
-
Notifications
You must be signed in to change notification settings - Fork 491
fix IDE updater commands #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AlbyIanna if you still want me to check this out, please do a rebase to trigger a build. The build workflow is configured to only run on PRs submitted to the main branch, so it didn't run on the previous push. Now that the base has been changed to main it will run on the next update to the PR.
But I see Francesco already gave it the 👍, so it is good to merge right away.
2c0ea45 to
d2e43fa
Compare
@per1234 ✅ done!
@per1234 I've just realised I'm not updating the channel configuration immediately when the user changes the channel preference. It's not done until the next IDE start-up. I'm going to fix it in this PR because I think it's pertinent.
@per1234 Done. Now it should work as expected, that is when you change the channel or the update URL and then check for updates, the updater will use the correct channel/URL.
P.S.: I've noticed the expand/collapse icons in the bottom-right notifications are "invisible". Fixing it in another PR.
arduino-ide-extension/src/browser/ide-updater/ide-updater-commands.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had noticed the previous somewhat odd behavior of the commands, where you had to use a sequence of commands like this to trigger an update:
- Arduino: Check for Arduino IDE updates
- Arduino: Download Arduino IDE updates
- Arduino: Install Arduino IDE updates
After which it would do the update regardless of whether the available version was newer than the current.
With this PR, the single command Arduino: Check for Arduino IDE updates does all that, and works the same as the automatic update offer. So I think it is a very nice improvement.
and also thought that the ones other than Arduino: Check for Arduino IDE updates didn't seem very useful. So I think this is a nice change.
I verified that this also fixes #847
Thanks Alberto!
Motivation
IDE updater commands are not working how expected. They work, but they are not giving any feedback to the user.
Change description
Remove useless commands. Leave only the "Check for Arduino IDE updates" command. When launching this command, if there is an update available, it opens the update dialog. If there isn't any update available or some error occurs, it shows a notification message.
Reviewer checklist