Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Go to download page when automatic update fails #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbyIanna merged 3 commits into main from go-to-download-page
Mar 1, 2022
Merged

Conversation

Copy link
Contributor

@AlbyIanna AlbyIanna commented Feb 28, 2022

Motivation

Errors happening during the automatic update aren't handled properly.

Change description

Whenever an error happens during the automatic update occurs, show a link to the download page to let the user download the IDE by themselves.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna changed the base branch from main to custom-update-url February 28, 2022 12:41
Base automatically changed from custom-update-url to main February 28, 2022 14:04
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Mar 1, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested under the following conditions:

  • Download fails due to a 404
  • Download fails due to using the .zip Linux build (which doesn't support auto-update)

Previously, either of these conditions resulted in the update download dialog hanging at 0%, with no feedback unless you checked the command line output (and even that wasn't clear in the case of using the .zip Linux build).

Now both of these situations are handled gracefully by the IDE.

Thanks Alberto!

AlbyIanna reacted with rocket emoji
@AlbyIanna AlbyIanna merged commit a5a6a0b into main Mar 1, 2022
@AlbyIanna AlbyIanna deleted the go-to-download-page branch March 1, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@fstasi fstasi fstasi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /