Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix board options not shown for manually installed platforms #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silvanocerza merged 1 commit into main from scerza/fix-missing-properties
Feb 14, 2022

Conversation

Copy link
Contributor

@silvanocerza silvanocerza commented Feb 11, 2022

Fixes #565.

Before:

before

After:

after

per1234 reacted with thumbs up emoji
@silvanocerza silvanocerza added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 11, 2022
@silvanocerza silvanocerza added this to the arduino-ide rc4 milestone Feb 11, 2022
Copy link
Contributor Author

@ubidefeo tested and the previous solution wasn't working for manually installed platform that didn't have version set in their platform.txt so I had to make some changes.

Another review is required I think. @fstasi

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#565 no longer occurs for me when using this build.

Thanks Silvano!

Copy link

Works as expected
thank you

@silvanocerza silvanocerza deleted the scerza/fix-missing-properties branch February 14, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

+1 more reviewer

@fstasi fstasi fstasi approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing board option and Programmer menus for manually installed platforms

AltStyle によって変換されたページ (->オリジナル) /