Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove stray brace from compilation error output #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
per1234 merged 1 commit into arduino:main from per1234:stray-brace
Jan 17, 2022
Merged

Remove stray brace from compilation error output #751

per1234 merged 1 commit into arduino:main from per1234:stray-brace
Jan 17, 2022

Conversation

Copy link
Contributor

@per1234 per1234 commented Jan 15, 2022

An extra brace was inadvertently introduced into a template literal used to format output text in the event of an error
during compilation. This caused the text to end in a pointless }

For example, compiling this sketch:

#error
void setup() {}
void loop() {}

Previously produced this output:

C:\Users\per\AppData\Local\Temp\.arduinoIDE-unsaved2022014-9692-1u5eon9.v425\sketch_jan14a\sketch_jan14a.ino:1:2: error: #error 
 #error
 ^~~~~
Compilation error: exit status 1}

After this change, the output text is as expected:

C:\Users\per\AppData\Local\Temp\.arduinoIDE-unsaved2022014-9692-1u5eon9.v425\sketch_jan14a\sketch_jan14a.ino:1:2: error: #error 
 #error
 ^~~~~
Compilation error: exit status 1

kittaakos reacted with thumbs up emoji
An extra brace was inadvertently introduced into a template literal used to format output text in the event of an error
during compilation. This caused the text to end in a pointless `}`
For example:
```
Compilation error: exit status 1}
```
After this change, the output text is as expected:
```
Compilation error: exit status 1
```
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 15, 2022
@per1234 per1234 self-assigned this Jan 15, 2022
@per1234 per1234 merged commit 66fc27e into arduino:main Jan 17, 2022
@per1234 per1234 deleted the stray-brace branch January 17, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

1 more reviewer

@silvanocerza silvanocerza silvanocerza approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /