-
-
Notifications
You must be signed in to change notification settings - Fork 489
Remove gRPC error code from error notifications #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@silvanocerza
silvanocerza
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Dec 3, 2021
@silvanocerza
silvanocerza
requested review from
fstasi,
ubidefeo,
AlbyIanna,
per1234 and
91volt
December 3, 2021 15:35
fstasi
fstasi
approved these changes
Dec 3, 2021
result.on('end', () => resolve());
});
} catch (e) {
const errorMessage = `Error while burning the bootloader: ${e.details}`;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know errors are not localized (yet)... but they should..
Maybe we can start adopting i18n for new errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silvanocerza btw the PR is good. 🪄
@silvanocerza
silvanocerza
force-pushed
the
scerza/better-errors-notification
branch
from
December 3, 2021 16:08
372a820 to
55da22d
Compare
@silvanocerza
silvanocerza
deleted the
scerza/better-errors-notification
branch
December 6, 2021 08:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Compilation error before:
image
Upload error before:
image
Compilation error after:
image
Upload error after:
image
Fixes #151.