Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Translating Arduino-IDE using Theia's nls API #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fstasi merged 1 commit into arduino:main from msujew:main-app-i18n
Oct 18, 2021

Conversation

Copy link
Contributor

@msujew msujew commented Oct 12, 2021

Hi team,

this PR adds translation keys for all user-facing strings inside of the Arduino-IDE using the Theia localization (nls) API.

Be aware that this does not add actual translations for the app. However, some strings are nevertheless translated, as they are contained by the vscode language pack.

How to test

  1. Start the app and observe that all user-facing strings are still correct (in English)
  2. Download a language pack of your choice from the vscode marketplace/ovsx registry.
  3. Unzip it and place it into the plugins folder
  4. Start the application and run the Configure Display Language command and change to your new language
  5. Open the File menu.
  6. Observe that some menu entries have been changed.

rsora, ubidefeo, fstasi, AlbyIanna, and silvanocerza reacted with heart emoji
Copy link

CLAassistant commented Oct 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 12, 2021
Copy link
Contributor

Great jobs! It works really well and without issue. Approving. 👍

image
image

Copy link
Contributor

fstasi commented Oct 14, 2021

@msujew the labels that are not translated are those coming from theia, is this assumption correct?

Copy link
Contributor Author

msujew commented Oct 14, 2021

@fstasi Yes and no. Those coming from Theia are not translated (as the appropriate PR isn't merged yet), as well as those that are specifically for your app (nls ids starting with arduino/*), since the Transifex pipeline isn't in place yet.

The only ones that are currently translated are the ones that are specified inside of the arduino-ide (like close/open/exit/etc.) but exist inside of the vscode language packs.
fstasi reacted with thumbs up emoji

@fstasi fstasi merged commit 11b75bd into arduino:main Oct 18, 2021
@msujew msujew deleted the main-app-i18n branch October 20, 2021 15:16
@rsora rsora mentioned this pull request Jan 11, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@fstasi fstasi fstasi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /