-
-
Notifications
You must be signed in to change notification settings - Fork 489
[ATL-1556] Sort board families in Tool menu #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubidefeo
ubidefeo
requested changes
Aug 26, 2021
@ubidefeo
ubidefeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the last artifact:
https://github.com/arduino/arduino-ide/actions/runs/1170340912
... On Thu, Aug 26, 2021 at 12:01 PM Ubi de Feo ***@***.***> wrote:
***@***.**** requested changes on this pull request.
nope.
[image: Screenshot 2021年08月26日 at 11 58 49]
<https://user-images.githubusercontent.com/1894487/130943483-94d126b8-241e-4d2d-9dfd-0097fab13ddd.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#486 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMPURJABJR2AD37E77SPSDT6YGGPANCNFSM5CYXUI6A>
.
--
Francesco Stasi
Sr Specialist Software Engineer
+39 3407859852
ARDUINO.CC <https://www.arduino.cc/>
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | |
This message is confidential and may be legally privileged or otherwise
protected from disclosure;
you must not copy or disclose the contents of this message or any
attachment to any other person.
ubidefeo
ubidefeo
approved these changes
Aug 26, 2021
@ubidefeo
ubidefeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase/Uppercase sorting is now resolved
LGTM
@fstasi
fstasi
deleted the
atl-1556--sort-board-families-alphabetically
branch
August 26, 2021 13:25
@per1234
per1234
added
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
labels
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Boards in the tool menu are not sorted properly, and make it difficult to select the right one when many platforms are installed.
How
Add "order" option to the menu elements equal to the name of the platform, so that they are displayed alphabetically
Taks
Jira Task