Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ATL-1556] Sort board families in Tool menu #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fstasi merged 2 commits into main from atl-1556--sort-board-families-alphabetically
Aug 26, 2021

Conversation

Copy link
Contributor

@fstasi fstasi commented Aug 25, 2021

Why

Boards in the tool menu are not sorted properly, and make it difficult to select the right one when many platforms are installed.

How

Add "order" option to the menu elements equal to the name of the platform, so that they are displayed alphabetically

Taks

Jira Task

per1234 reacted with thumbs up emoji
@fstasi fstasi requested a review from ubidefeo August 25, 2021 10:22
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

fstasi commented Aug 26, 2021 via email

...
On Thu, Aug 26, 2021 at 12:01 PM Ubi de Feo ***@***.***> wrote: ***@***.**** requested changes on this pull request. nope. [image: Screenshot 2021年08月26日 at 11 58 49] <https://user-images.githubusercontent.com/1894487/130943483-94d126b8-241e-4d2d-9dfd-0097fab13ddd.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#486 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMPURJABJR2AD37E77SPSDT6YGGPANCNFSM5CYXUI6A> .
-- Francesco Stasi Sr Specialist Software Engineer +39 3407859852 ARDUINO.CC <https://www.arduino.cc/> | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This message is confidential and may be legally privileged or otherwise protected from disclosure; you must not copy or disclose the contents of this message or any attachment to any other person.

Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase/Uppercase sorting is now resolved
LGTM

@fstasi fstasi merged commit d3d6ba8 into main Aug 26, 2021
@fstasi fstasi deleted the atl-1556--sort-board-families-alphabetically branch August 26, 2021 13:25
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /