-
-
Notifications
You must be signed in to change notification settings - Fork 489
Fix url to open sketch in cloud editor #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlbyIanna
merged 1 commit into
main
from
atl-1432-url-to-open-sketch-in-webide-is-wrong
Jul 23, 2021
Merged
Fix url to open sketch in cloud editor #452
AlbyIanna
merged 1 commit into
main
from
atl-1432-url-to-open-sketch-in-webide-is-wrong
Jul 23, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstasi
fstasi
approved these changes
Jul 15, 2021
@AlbyIanna
AlbyIanna
force-pushed
the
atl-1432-url-to-open-sketch-in-webide-is-wrong
branch
from
July 22, 2021 12:52
aac7d33 to
16ba1a2
Compare
@fstasi
fstasi
deleted the
atl-1432-url-to-open-sketch-in-webide-is-wrong
branch
July 23, 2021 13:00
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Oct 24, 2021
@per1234
per1234
added
the
topic: cloud
Related to Arduino Cloud and cloud sketches
label
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
When opening a sketch in the Cloud editor through the contextual menu in the Remote Sketchbook, the user is redirected to the wrong URL.
It should link to: "create.arduino.cc/[USERNAME]/[SKETCH_ID]"
But right now it links to: "create.arduino.cc/[SKETCH_ID]"
Which results in the editor opening the first sketch in the list
HOW
Pass the username as an argument when executing the command to open the contextual menu.