-
-
Notifications
You must be signed in to change notification settings - Fork 491
Footer min-height for library and board manager #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Increase the `min-height` from 26px to 30px to prevent the list items from changing height when mousing over them
CLA assistant check
All committers have signed the CLA.
I have verified the changes locally on macOS. It works as described. Thank you for the patch 👍
+1 for merging it.
Is there any chance of this being merged? I've just installed beta 10 and this issue hasn't been fixed by any other changes. It's quite jarring - I'm autistic and the jump feels painful (which was my motivation for finding a fix in the first place!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IrregularShed, this works for me! ✅
Thank you so much for contributing and sorry for the big delay in approving this PR! 🙏
On Windows 10 (and possibly others), rolling over the items in the Library Manager and Boards Manager causes an unpleasant jump, as seen here:
ezgif com-gif-maker
This PR increases the
min-heightof the footer for the list items from 26px to 30px, which is the minimum value required to prevent this from occurring, and improves the UX in doing so, without changing the spacing excessively:ezgif com-gif-maker (1)