Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add agpl-3.0 LICENSE.txt file #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silvanocerza merged 1 commit into main from scerza/license
Feb 25, 2021
Merged

Add agpl-3.0 LICENSE.txt file #32

silvanocerza merged 1 commit into main from scerza/license
Feb 25, 2021

Conversation

Copy link
Contributor

@silvanocerza silvanocerza commented Feb 25, 2021

No description provided.

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Silvano 👍

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correctly recognized by GitHub's license detection system:
Clipboard01
(checked by setting scerza/license to default branch in my fork)

I guess headers will also need to be added to the code in a separate PR?

Copy link
Contributor Author

silvanocerza commented Feb 25, 2021
edited
Loading

I guess headers will also need to be added to the code in a separate PR?

I don't think it's necessary, a top level license file covers all files in the folders below if am not mistaken.

By the way am merging without waiting for checks to pass, this change doesn't affect code.

@silvanocerza silvanocerza deleted the scerza/license branch February 25, 2021 10:11
Copy link
Contributor

per1234 commented Feb 25, 2021

I'm just going off this, and what I've seen in practice:

arduino-ide/LICENSE.txt

Lines 627 to 630 in 79b1a30

To do so, attach the following notices to the program. It is safest
to attach them to the start of each source file to most effectively
state the exclusion of warranty; and each file should have at least
the "copyright" line and a pointer to where the full notice is found.

I prefer not to have those things cluttering up the code though.

Copy link
Contributor

We should also update the license filed in the package.jsons:

"license": "MIT",
silvanocerza and rsora reacted with thumbs up emoji

@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /