-
-
Notifications
You must be signed in to change notification settings - Fork 489
ATL-786: Progress indication for install. #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATL-786: Progress indication for install. #305
Conversation
6a73507 to
e48def5
Compare
Just tested and I like this enhancement, my only concern is that probably the bar might be too small, could it be made a bit thicker or the size is fixed?
ould it be made a bit thicker or the size is fixed?
Yes, we can do that. Also, the default color should not be the hardcoded blue from Theia but aligned with the status bar color. I think it is blue.
I wanted to reset the progress bar between the tasks (there is no progress for tasks, only for downloads), and use an unknonwk progress indicator, but it does not seem to work. (Related: eclipse-theia/theia#9323)
Yes, we can do that.
and use an unknonwk progress indicator
I have updated the PR. Here it is in action. Now, the progress bar can jump between unknown and normal mode:
e48def5 to
54cf4b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, it's so much better now!
54cf4b0 to
85059a9
Compare
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
85059a9 to
54e5746
Compare
I am merging this into the other PR.
8e16c7e
into
atl-1195--show-all-examples-when-no-board-selected
This PR gets rid of the modal dialogs when installing/uninstalling libs and platforms.
Signed-off-by: Akos Kitta kittaakos@typefox.io