CLA assistant check
All committers have signed the CLA.

We decided to run the gRPC equivalent of arduino-cli lib list when no board is selected, or the core of the selected board is not installed. In this case, we will show the examples/libs from the user-installed libs. Otherwise, (when a board is selected and the core is installed), we run the gRPC equivalent of arduino-cli lib list --all --fqbn the:current:fqbn command.

hi @kittaakos
I found a few issues with some of the fixes

• ATL-1195: Show examples if no board is selected.

right now I cannot have the "no board selected" situation because of ATL-1206, so I erased the preference folder .arduinoIDE expecting the IDE to forget the last selected board, and instead of showing no board selected I got ESP 32 Dev Module automatically selected but I had not used this board in the sketch.
The board was used previously but I have no idea where it picked it from once the preferences folder was erased

• ATL-1195: Show all libraries if no board selected.

because of the above I cannot test this one.
It will be less of a problem once a board has ever been selected, but at first launch it will still be.
I need ways to reliably recreate the first launch, with no board selected and deleting .arduinoIDE doesn't seem to do it

• Notify user if platform/lib install was successful
  This shows the notification and it's good for now

GH-297: Fixed the open from Sketchbook handler.
This added a regression. If the sketch is already open, it will open a duplicate of it in a new window, but this will only happen the first time.
If I try again, and I already have 2 open of the same it will not open a 3rd one

• ATL-1207: Open editor if file was added to sketch.
  works when:

• adding to or removing a file from the Sketch folder
• renaming a file from the Sketch folder
  does not work when:
• copy/paste a file on Mac, as it gets "duplicated" with the filename copy.ext format. I thought it could be the space in the name but renaming an existing file adding a space reflects in the open tab changing name

• ATL-1206: Reuse selected board for new sketches.
  works

• ATL-1215: Updated to the 20210408 CLI.
  verified

right now I cannot have the "no board selected" situation because of ATL-1206, so I erased the preference folder .arduinoIDE expecting the IDE to forget the last selected board, and instead of showing no board selected I got ESP 32 Dev Module automatically selected but I had not used this board in the sketch.

If you want to "unset" the selected board, you have to open the DevTools, write localStorage.clear() to the console, press enter, and reload the page with Ctrl/Cmd+R when the DevTools has the focus.

• thought it could be the space in the name but renaming an existing file adding a space reflects in the open tab changing name

A sketch file cannot contain space. Your macOS-based copy/paste will result in an invalid sketch file name. So the IDE does not open that file. This behaves the same with the Java IDE. I do not think this is a bug.

I found this in the logs:

root ERROR Request installed failed with error: 2 UNKNOWN: loading board data: unknown package arduino Error: 2 UNKNOWN: loading board data: unknown package arduino
 at Object.callErrorFromStatus (/Users/akos.kitta/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
 at Object.onReceiveStatus (/Users/akos.kitta/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/client.js:176:52)
 at Object.onReceiveStatus (/Users/akos.kitta/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:336:141)
 at Object.onReceiveStatus (/Users/akos.kitta/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
 at /Users/akos.kitta/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/call-stream.js:145:78
 at processTicksAndRejections (internal/process/task_queues.js:76:11)

It looks suspicious. unknown package arduino; there is no package arduino. It should be arduino:avr, arduino:samd, etc.

This happens when calling BoardDetails right? What's the FQBN used to make the call?

This happens when calling BoardDetails right?

I thought the same, but no. lib list has the same error message as board details and this 👆 comes from lib list.

• https://github.com/arduino/arduino-cli/blob/a4ee670a9233a107bb89d4cfe0c48ab40aba9076/commands/board/details.go#L44
• https://github.com/arduino/arduino-cli/blob/a4ee670a9233a107bb89d4cfe0c48ab40aba9076/commands/lib/list.go#L60

lib list too can accept an FQBN, that error can happen only in case the passed FQBN is malformed. Could this be caused by the changes needed to show examples in the dropdown menu even when no board is selected?

Everything seems to work, but I'm still able to create a new Tab with a space in the name.
Shall we create an issue for it?

Everything seems to work

FYI: We have an issue with the CLI, I believe. It's super easy to reproduce, wipe directories.data and start the app, after InitRequest, and the lib and platforms index updates, search does not work, for instance. We cannot propose users to auto-install cores, etc. There is a timing issue somewhere. So any new users will have this issue. We can discuss it tomorrow, online.

This PR is blocked by eclipse-theia/theia#9349.

I have fixed the outstanding issues. It's ready for review.

Thank you for the review. I am merging the changes to the main.