-
-
Notifications
You must be signed in to change notification settings - Fork 489
ATL-1145: Suppress error if Git is not on $PATH.
#294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
rsora
rsora
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in a clean Win environment:
- latest nightly: I can see the error message
- Build from this PR: I can't see the error anymore
👍
Thank you for the review.
@per1234
per1234
added
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
labels
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does one thing: it suppresses the error message when the Git executable is not on the
$PATH.How to verify: this is an interesting part, I did the straightforward way and renamed all my Git executables to something else so that
git versionfails from a terminal. I renamed the followings:C:\Program Files\Git\cmd\git.exe,C:\Users\my_name\scopes\shims\git.EXE, and/mingw64/bin/git(for Git Bash) also not accessible.Once you have a setup without git on the
$PATH, start the app. You should not see any errors.Signed-off-by: Akos Kitta kittaakos@typefox.io