Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Order custom board option menus as defined in platform configuration #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gneiss15 wants to merge 3 commits into arduino:main
base: main
Choose a base branch
Loading
from gneiss15:Issue_2036
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix for Issue 2036 
Title: Custom board option menus not following the order sent by the cli
Fixes "Custom board option menus not following the order inside boards.txt"
Line 74-76 of "boards-data-menu-updater.ts":
 for (const { label, option, values } of configOptions.sort(
 ConfigOption.LABEL_COMPARATOR
 )) {
New Line 74:
 for (const { label, option, values } of configOptions ) {
IMHO using sort on configOptions will produce the mentioned failure.
Simply don't sort and the order will be as in Arduino IDE 1.x (as desfined inside board.txt)
I don't have the tools to build and test this change.
I use the AppImage "arduino-ide_2.3.6_Linux_64bit.AppImage"
Signed-off-by: Günter Neiß <gneiss@web.de>
  • Loading branch information
gneiss15 committed Apr 22, 2025
commit 62aee5cbddc5030bcead544763ef78b3f93cd83a
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ export class BoardsDataMenuUpdater extends Contribution {
...ArduinoMenus.TOOLS__BOARD_SETTINGS_GROUP,
'z01_boardsConfig',
]; // `z_` is for ordering.
for (const { label, option, values } of configOptions.sort(
ConfigOption.LABEL_COMPARATOR
)) {
for (const { label, option, values } of configOptions ) {
const menuPath = [...boardsConfigMenuPath, `${option}`];
const commands = new Map<
string,
Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /