-
-
Notifications
You must be signed in to change notification settings - Fork 488
fix: use ElectronConnectionHandler to connect the ide updater frontend and the electron main process
#2697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@giacomocusinato
giacomocusinato
temporarily deployed
to
production
April 8, 2025 15:48 — with
GitHub Actions
Inactive
@giacomocusinato
giacomocusinato
added
type: imperfection
Perceived defect in any part of project
topic: theia
Related to the Theia IDE framework
labels
Apr 8, 2025
@giacomocusinato
giacomocusinato
changed the title
(削除) fix: use
(追記) fix: use Apr 8, 2025
ElectronConnectionHandler to connect ide updater services (削除ここまで)ElectronConnectionHandler to connect the ide updater frontend and the electron main process (追記ここまで)
per1234
per1234
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes #2696
Thanks Giacomo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2696
Change description
Use
ElectronConnectionHandlerinstead ofConnectionHandlerto establish communication between the frontend and the electron main process. This is needed specifically for services interacting with electron.Other information
The issue seems to appear also on the Theia IDE example. An issue will follow on Theia side.