-
-
Notifications
You must be signed in to change notification settings - Fork 490
feat: use theia@1.57.0
#2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use theia@1.57.0
#2654
Conversation
4d57906 to
6e9577a
Compare
7868bdb to
cb91633
Compare
theia@latest (削除ここまで)theia@latest (追記ここまで)
theia@latest (削除ここまで)theia@latest (追記ここまで)
46637f4 to
8a4b727
Compare
theia@latest (削除ここまで)theia@1.57.0 (追記ここまで)
a69a4e5 to
3adbd1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
Outdated
Show resolved
Hide resolved
electron-app/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! However, it depends on your release plan. I would be happy to see the new API integrated into the IDE nightly, and everything should be compatible, but I can't guarantee anything. If any issues arise, I'm available to help resolve them, or you can revert to a previous version if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would merge this PR once ready and release next week after a weekend of nightly test.
I won't mind also postponing the vscode-arduino-api update to the release after this one, to allow for longer nightly testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose reverting the changes for now, and after the IDE release, I will create a follow-up PR. Thank you!
The Theia update is supposed to fix #2148. It would make sense to verify if the CLI daemon can reconnect. The LS reconnection will fail. See here:
Update: I have not verified it, but I assume IDE has to create a new daemon instance on reconnect, therefore the instance number will change.
Use changes from #2362 and rebase on main branch
Remove `EditorCommandContribution` override, since https://redirect.github.com/eclipse-theia/theia/pull/13683 fixed the unwanted save on startup
Note: align SidebarBottomMenuWidget with Theia new API and HTML structure
Electron version is now pinned, so replace caret only if found
e6cf3cf to
f3a2eb9
Compare
Uh oh!
There was an error while loading. Please reload this page.
Motivation
Use
theia@1.57.0.Note that newer versions are currently not working because of ESM incompatibilty. See theia issue and Prototype ESM-only package workaround for unbundled back end
Change description
Based on #2362
The first commit includes all changes from #2363 rebased into main branch.
Main changes needed for upgrades after
theia@1.46.1:EditorCommandContributionoverride (1fa0def), since Theia runs save on app startup if"editor.autoSave": "on"is configured in the settings.json eclipse-theia/theia#8722 has been fixed intheia@1.51.0through this PRtheia@1.53.2; this was needed for some incompatibility with electron builder. After the upgrade, some custom package resolutions is required, (see issue)TreeViewWidgetpatches sincetheia@1.55.1. See fix: alignviewsWelcomebehavior to VS Code #2543Other information
Know issues:
onPointerEnterCapture. Tracked in https://redirect.github.com/eclipse-theia/theia/issues/14633Reviewer checklist