ATL-1106: Made all non-workspace editors read-only. #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kittaakos merged 1 commit into main from atl-1106--readonly-on-monaco-peek

Mar 25, 2021

Merged

ATL-1106: Made all non-workspace editors read-only. #264

kittaakos merged 1 commit into main from atl-1106--readonly-on-monaco-peek

Mar 25, 2021

Conversation

kittaakos

Copy link

Contributor

@kittaakos kittaakos commented Mar 24, 2021

What it does:

This PR makes all editors that are not in the current workspace (sketch folder) read-only.

Try the Peek > Peek Definiton functionality on Serial#begin and bar. (Note the cursor location: <|>):

Sketch.ino:

#include "other.h"
void setup() {
 ba<|>r();
 Serial.begi<|>n(9600);
}
void loop() { }

Other.h:

void bar() {}

Serial#begin should open in a read-only embedded editor. You should be able to edit in the embedded editor if you peek at the definition of bar. Opening an editor should behave the same as the embedded peek editor. Please review. Thank you!

Signed-off-by: Akos Kitta kittaakos@typefox.io

@kittaakos kittaakos requested a review from per1234

March 24, 2021 11:40


 ATL-1106: Made all non-workspace editors read-only.

c6a1db4

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

@kittaakos kittaakos force-pushed the atl-1106--readonly-on-monaco-peek branch from 4ba8bb9 to c6a1db4 Compare

March 24, 2021 11:48

@kittaakos kittaakos requested a review from fstasi

March 24, 2021 11:49

per1234

per1234 approved these changes

Mar 24, 2021

View reviewed changes

Copy link

Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great Akos. Thanks!

I did find a related problem, which is that the tab control menu allows me to delete or rename the files opened via "Go to Definition". I could see a user using "delete" to remove what appears to be an unwanted file from their sketch. But I'm guessing that is out of scope for this PR, so I'm giving a resounding thumbs up on this.

@ubidefeo

Copy link

ubidefeo commented Mar 25, 2021

Downloading now, but I share @per1234 's opinion that non-workspace files should not be deleted.
I see one problem ahead: are files in the Sketch's src folder considered Workspace file?
Those ones should be editable and deletable.
Can of worms, anyone?