-
-
Notifications
You must be signed in to change notification settings - Fork 489
ATL-970: notification to last longer #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ubidefeo
commented
Mar 23, 2021
@fstasi
the build fails, I'll test this tomorrow
@ubidefeo I reran the build and it passed this time so it's all ready for testing. The failure was only caused by a temporary external network outage; nothing related to the code here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks good to me, but the base branch is incorrect for this PR. This PR should not contain the keymap + preferences changes. Please fix it. Thank you!
1f677d7 to
83b1666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The code looks to me. 👍
Please merge once you have the final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests on Win are 👍
With this PR I set the timeout of the following notification to 3 seconds (like other notifications in the IDE)