-
-
Notifications
You must be signed in to change notification settings - Fork 491
Create separate tester artifacts for each build #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously, the build CI/CD workflow had many occurrences of the string "build-artifacts" used for the workflow artifact name. This made the workflow more difficult to understand and maintain. Now a single workflow scoped environment variable is used to define the artifact name.
Previously, a single workflow artifact was created by the "Arduino IDE" GitHub Actions workflow. This artifact contained the builds for each operating system, including all three versions of the Windows build. This resulted in beta testers needing to do a >1 GB download for every build, even though they likely needed only ~200 MB of what they downloaded. Producing separate workflows makes it easier for beta testers to participate in the development and is less wasteful of resources.
ubidefeo
commented
Mar 23, 2021
thank you, @per1234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the macOS artifact, and it worked. Thank you!
I would have moved the artifacts step right after the build one, but it's a personal preference.
The "Arduino IDE" GitHub Actions workflow uses a workflow artifact to transfer the build artifacts between jobs. Now that separate tester build artifacts are produced, the monolithic job transfer artifact is superfluous once the workflow run is finished. Deleting it avoids potential confusion for beta testers and unnecessary storage space usage.
I would have moved the artifacts step right after the build one, but it's a personal preference.
OK, it is now done: https://github.com/arduino/arduino-ide/compare/5cb544c15837e63aace2fd0163a3e187a5713293..a3287ca1de656d8d5442941b85751e6e08f5d6e5
Uh oh!
There was an error while loading. Please reload this page.
Previously, a single workflow artifact was created by the "Arduino IDE" GitHub Actions workflow. This artifact contained
the builds for each operating system, including all three versions of the Windows build. This resulted in beta testers
needing to do a >1 GB download for every build, even though they likely needed only ~200 MB of what they downloaded.
Producing separate workflow artifacts makes it easier for beta testers to participate in the development and is less wasteful of
resources.