fix: storage service injection #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kittaakos merged 1 commit into main from #2240

Sep 27, 2023

Merged

fix: storage service injection #2241

kittaakos merged 1 commit into main from #2240

Sep 27, 2023

Conversation

kittaakos

Copy link

Contributor

@kittaakos kittaakos commented Sep 27, 2023 •

edited

Loading

Motivation

Store the board config data per sketch and not per IDE installation.

The (Theia) default StorageService implementation is workspace-scoped when @theia/workspace is part of the final application.

Change description

Changed the injection key to use the workspace-scoped storage service for the custom board options.

Other information

Closes #2240

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among the Pull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code type: imperfection labels

Sep 27, 2023

@kittaakos kittaakos requested a review from per1234

September 27, 2023 10:42

@kittaakos kittaakos self-assigned this

Sep 27, 2023


 fix: storage service injection

266d8f2

Store the board config data per sketch and not per IDE installation.
The (Theia) default `StorageService` implementation is workspace-scoped
when `@theia/workspace` is part of the final application.
Closes #2240
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>