-
-
Notifications
You must be signed in to change notification settings - Fork 492
chore(deps): update electron+electron-builder
#2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
added
the
topic: code
Related to content of the project itself
label
Aug 14, 2023
to fix flaky build Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
I created this PR as the first attempt to fix eclipse-theia/theia#12751.
It does not fix anything.
@per1234
per1234
added
topic: infrastructure
Related to project infrastructure
type: imperfection
Perceived defect in any part of project
and removed
topic: code
Related to content of the project itself
labels
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates the version of the
electronandelectron-builderdependencies. I created this PR as the first attempt to fix eclipse-theia/theia#12751.Change description
This PR updates the dependencies to
electron@25.5.0andelectron-builder@24.6.3.Other information
Related error messages and issues:
(when started with
--disable-gpu):To verify:
- CI works,
- after downloading and starting the tester build, verify the
- Open the Dev Tools in IDE2 (Ctrl/⌘+Alt+I),
- Open Console (with Esc) if not opened,
- Type:
- It must be
Screenshot 2023年08月14日 at 14 20 14electronversion:navigator.userAgent, and press Enter.Electron/25.5.0. The rest could be different per OS:Reviewer checklist