fix: relaxed `saveAll` if no Internet connection #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kittaakos merged 1 commit into main from #2079

Jun 8, 2023

Merged

fix: relaxed `saveAll` if no Internet connection #2080

kittaakos merged 1 commit into main from #2079

Jun 8, 2023

Conversation

kittaakos

Copy link

Contributor

@kittaakos kittaakos commented May 30, 2023 •

edited

Loading

Motivation

Saving any (local and cloud) sketches without an Internet connection must be possible. (Pulling/pushing cloud sketch changes are expected to not work without the Internet.)

Change description

The previous logic has incorrectly bailed the save when there is no Internet connection. The corrected logic disallows saving files if there is no connection between the front and backend.

Other information

How to verify the fix:

open IDE2, create a new sketch, turn auto-save off, disconnect from the Internet (you will see the yellow Offline status bar),
modify the sketch and save it. It works. Restart IDE2, and you will see the updated sketch content.

Reviewer checklist

This PR does not fix #2081.
Ref: cff2c95
Closes #2079

PR addresses a single concern.
The PR has no duplicates (please search among the Pull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)


 fix: relaxed saveAll if no Internet connection

d1843ff

The previous logic has incorrectly bailed the save when there is no
Internet connection. The corrected logic disallows saving files if there
is no connection between the frontend and the backend.
Ref: cff2c95
Closes #2079
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>