Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

add linux-arm64 to download-ls #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 2 commits into arduino:main from streak324:linux_arm64_download_ls
Jun 12, 2023

Conversation

Copy link
Contributor

@streak324 streak324 commented May 28, 2023

Motivation

I want to locally build arduino ide on a linux arm64 machine.

Change description

Updates one of the build scripts, so that the ide can build succesfully on linux arm64.

Tested on Orange Pi 5, Armbian distro.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Copy link

CLAassistant commented May 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure architecture: arm Specific to ARM host architecture os: linux Specific to Linux operating system labels May 29, 2023
@kittaakos kittaakos self-requested a review June 1, 2023 12:45
@per1234 per1234 added the topic: language server Related to the Arduino Language Server label Jun 8, 2023
Copy link
Contributor

Thank you for your contribution, @streak324.

I do not have access to an ARM64 machine, so I have to request build output from you to verify if it will work or if something needs to be adjusted in this PR. Did you create an electron application or start IDE2 from the sources? If you built the app, could you share the full output? If you have not built the app, the steps are the following assuming you're in the repository root:

yarn --cwd ./electron/packager/
yarn --cwd ./electron/packager/ package

could you share the full output

The best would be to rebase the PR from the main (8f8b46f) branch and rerun the application packaging. Please put the packager output into a file and attach it to the PR for verification. I appreciate your help.

Copy link
Contributor Author

Hi. I merged the main branch to my PR. I was following the instructions in BUILDING.md to run the app locally, but I don't have logs from running it though.

Here is the attached log output from those two yarn commands. The built AppImage binary in ./electron/build/dist runs fine.
build.log

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @streak324 👍

I do not have access to an ARM64 env, but your build output looks correct.

streak324 reacted with rocket emoji
@kittaakos kittaakos merged commit d79bc0d into arduino:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kittaakos kittaakos kittaakos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
architecture: arm Specific to ARM host architecture os: linux Specific to Linux operating system topic: infrastructure Related to project infrastructure topic: language server Related to the Arduino Language Server type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /