-
-
Notifications
You must be signed in to change notification settings - Fork 491
fix: show no errors if users cancel lib install #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwing and catching a `UserAbortError` is part of the natural flow. Closes #2063 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
May 11, 2023
per1234
per1234
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Akos!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With #2061, IDE2 shows an error notification if an error was caught during the platform/library installation. This is all good, but IDE2 throws
UserAbortErrorwhen the user interrupts the installation process. In such a case, no error notification is needed.Change description
Catch and swallow
UserAbortErrorduring the installation.How to verify:
Forced-BME280library; the installation fails, and the cause of the error is shown to the user as an error notification.2063_fix.mp4
Other information
Closes #2063
Apologies for the double review, Per.
Reviewer checklist