Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: updated to electron-builder@23.6.0 #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 2 commits into main from #1801
Apr 13, 2023
Merged

fix: updated to electron-builder@23.6.0 #1986

kittaakos merged 2 commits into main from #1801
Apr 13, 2023

Conversation

Copy link
Contributor

@kittaakos kittaakos commented Mar 31, 2023 •
edited
Loading

Motivation

To fix the auto-updater defect on Windows caused by a library used by IDE2.

I downloaded the build artifacts and verified them on different OSs:

  • macOS (12.3.6) (dmg),
  • Linux (Ubuntu 22.04) (zip, AppImage),
  • Windows (10 Pro, 21H2) (MSI, interactive installer)

I verified the followings: the app starts, can upload to the board, and the LS works.

Change description

  • Use electron-builder@23.6.0,
  • Set the CSC_FOR_PULL_REQUEST env variable in the workflow to run the signing part for PRs.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added os: windows Specific to Windows operating system type: imperfection Perceived defect in any part of project labels Mar 31, 2023 
set `CSC_FOR_PULL_REQUEST` env to run notarization for a PR build.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos self-assigned this Apr 3, 2023
@kittaakos kittaakos marked this pull request as ready for review April 3, 2023 08:25
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch on macOS (Monterey 12.3.1) by changing the version locally in the package.json and then producing a build of the IDE. The updater dialog showed up and I was able to download the update without any issues. Good enough for me! ✅

Copy link
Contributor Author

I want to merge this change too. Any objections, Per?
per1234 reacted with eyes emoji

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used Alberto's wonderful arduino.ide.updateBaseUrl setting to test updates from and to the test build on Windows and Linux and everything works as expected.

Thanks Akos!

@kittaakos kittaakos merged commit 96da5bb into main Apr 13, 2023
@kittaakos kittaakos deleted the #1801 branch April 13, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
os: windows Specific to Windows operating system type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /