-
-
Notifications
You must be signed in to change notification settings - Fork 491
Allow leading underscore in sketch filenames #1955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before relaxing the sketch folder and filename validation in this PR, IDE2 used 0 as the default first character (defaultFallbackFirstChar). See here:
Can IDE2 drop 0 as the default first char and use an underscore (_) instead? What do you think?
use an underscore (_) instead? What do you think?
It's fine by me. That is actually what Arduino IDE 1.x does when you try to save a sketch with an invalid first character (it uses _ as the replacement character regardless of position).
Shall I update the PR accordingly?
It's fine by me.
Shall I update the PR accordingly?
If you agree with this change, doing it in this PR would be great. Thanks!
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino IDE enforces compliance with the specification in order to ensure sketches created with Arduino IDE can be used with any other Arduino development tool. The Arduino Sketch Specification has been changed to allow a leading underscore in sketch folder names and sketch code filenames so IDE's sketch name validation must be updated accordingly.
828bd87 to
a8ec75d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Thank you for taking care of it.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino IDE enforces compliance with the specification in order to ensure sketches created with Arduino IDE can be used with any other Arduino development tool.
The Arduino Sketch Specification is being changed to allow a leading underscore in sketch folder names and sketch code filenames:
arduino/arduino-cli#2105
Change description
Update Arduino IDE's sketch name validation according to the specification change.
Reviewer checklist