-
-
Notifications
You must be signed in to change notification settings - Fork 490
fix: jsonc parsing in the IDE2 backend #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Mar 10, 2023
Occurred when `settings.json` contained comments or a trailing comma. Closes #1945 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1945
branch
from
March 10, 2023 14:45
6041a32 to
309a82b
Compare
AlbyIanna
AlbyIanna
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM 👍
per1234
per1234
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Relaxed the
settings.jsonparsing in the IDE2's backend. The problem occurred when thesettings.jsoncontained comments or a trailing comma.Change description
Use
jsonc-parserand allow comments, a trailing comma, and empty content.Other information
Reviewer checklist
Closes #1945