Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Auto-select boards config with hardwareId if present #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davegarthsimpson wants to merge 13 commits into main from include-hardwareId-in-auto-selection

Conversation

Copy link
Contributor

@davegarthsimpson davegarthsimpson commented Feb 13, 2023 •
edited
Loading

Motivation

To ensure boards not exposing an fqbn can still be "auto-selected", considering their hardwareId.

Change description

Retrieves hardwareId of a discovered port from the CLI.

Considers hardwareId of a discovered port when determining whether or not to "auto-select" a port.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@davegarthsimpson davegarthsimpson changed the title (削除) Auto-select boards config with hardwareId if present (削除ここまで) (追記) Auto-select boards config with hardwareId if present (追記ここまで) Feb 13, 2023
Copy link
Contributor

@per1234 per1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: Resolved by cf6f83c

(削除) This must be updated to `1.19`:
GO_VERSION: "1.17"
(削除ここまで)

(削除) Reference: arduino/arduino-cli#2026
(削除ここまで)

Copy link
Contributor

per1234 commented Feb 22, 2023 •
edited
Loading

UPDATE: Resolved by cf6f83c

(削除) And the same change in the other workflows as well: (削除ここまで)

(削除) (削除ここまで)

(削除)
GO_VERSION: "1.17"
(削除ここまで)
(削除)
(削除ここまで)

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 22, 2023
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE2 should not use the HEAD of the master branch.

@per1234 per1234 self-requested a review February 22, 2023 10:44
Copy link
Contributor

The build is failing due to a breaking change in the CLI. See #1809 (comment) for details.

Copy link
Contributor Author

The build is failing due to a breaking change in the CLI. See #1809 (comment) for details.

thanks for the heads up! @kittaakos can we resolve this with just a change of this line?

Copy link
Contributor

can we resolve this with just a change of this line?

Correct, IDE2 needs to adapt there. 👍

@davegarthsimpson davegarthsimpson marked this pull request as ready for review February 22, 2023 15:19
@kittaakos kittaakos self-requested a review February 22, 2023 15:23
Copy link

@davegarthsimpson
can you take care of the 2 changes requested?

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I did not verify it.

Copy link
Contributor Author

@davegarthsimpson can you take care of the 2 changes requested?

@ubidefeo already done I believe!

lastBoardsConfigOnUpload.selectedBoard
);

if (!boardIsSameHardware && !boardIsSameFqbn) return;
Copy link
Contributor

@kittaakos kittaakos Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here: #1913 (review)

Copy link
Contributor Author

@davegarthsimpson davegarthsimpson Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

closing in favor of #1913

@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 24, 2023
@per1234 per1234 deleted the include-hardwareId-in-auto-selection branch August 1, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 Awaiting requested review from per1234

1 more reviewer

@kittaakos kittaakos kittaakos approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /