-
-
Notifications
You must be signed in to change notification settings - Fork 488
feat: icon for cloud sketch in File > Open Recent #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
42f6237
to
65add68
Compare
048f452
to
adf3dcf
Compare
@kittaakos is this pending a design decision? Thanks
If IDE2 wants to dispatch images on the selected theme
@kittaakos is this pending a design decision? Thanks
@davegarthsimpson, yes.
91volt
commented
Mar 24, 2023
@kittaakos the icon looks great.
-> if is possible to make the icons theme dependent would be great. Tell me if you need assets for that.
-> If is not feasible to have it in time for our next release, for now we can adopt the same solution of the titlebar, with "Cloud" textual prefix.
wdyt?
-> if is possible to make the icons theme dependent would be great. Tell me if you need assets for that.
Yes, IDE2 needs the icons if the feature is required. Please see the PR description with the electron restrictions on the icon.
-> If is not feasible to have it in time for our next release,
I am not in the loop, I do not even know when does the next release happen.
Ref: #1826 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
65add68
to
c8e447c
Compare
If IDE2 wants to dispatch images on the selected theme
Dispatching the icon based on IDE2's theme is not the best idea. The OS native menu is still dark, although the IDE2's theme is light. Please decide, @91volt. Thanks!
In-action:
cloud_icon_ide_theme.mp4
Dispatching the icon based on IDE2's theme is not the best idea.
Another approach could be using the nativeTheme
from Electron.
CLAassistant
commented
Apr 1, 2024
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Uh oh!
There was an error while loading. Please reload this page.
Depends on #1833
Motivation
As asked for in #1826, IDE2 would like to show an icon for cloud sketches in File > Open Recent.
This is just the infrastructure and an example of how IDE2 can render a custom image for a menu item. The images are missing from the PR. Here is the documentation of supported native image formats. If IDE2 wants to dispatch images on the selected theme, I am happy to update the PR.
Screen Shot 2023年02月08日 at 14 33 58
Source of my example cloud image: https://imagensemoldes.com.br/wp-content/uploads/2020/04/%C3%8Dcone-Computador-Nuvem-PNG.png
Change description
nativeImage
.directories.data/RemoteSketchbook
.Other information
Ref: #1826
Reviewer checklist