-
-
Notifications
You must be signed in to change notification settings - Fork 490
fix: sketchbook container building #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
force-pushed
the
#1185
branch
from
January 11, 2023 09:05
b15a640 to
f54e072
Compare
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Jan 11, 2023
@kittaakos
kittaakos
force-pushed
the
#1185
branch
from
January 11, 2023 09:19
f54e072 to
985cb32
Compare
Closes #1185 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1185
branch
from
January 11, 2023 15:57
985cb32 to
ffd1455
Compare
per1234
per1234
approved these changes
Jan 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Akos!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
To fix the sketchbook folder structure in IDE2:
File>SketchbookChange description
I completely rewrote the logic. The best is to verify with the test sketchbook IDE2 uses:
__test_sketchbook__.From now on, IDE2 gracefully handles when the sketchbook location is a sketch folder.
In action:
1185.mp4
Other information
Closes #1185
Reviewer checklist