Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: Use latest LS with the URL encoding fixes #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 3 commits into main from #1124
Jan 16, 2023
Merged

chore: Use latest LS with the URL encoding fixes #1811

kittaakos merged 3 commits into main from #1124
Jan 16, 2023

Conversation

Copy link
Contributor

@kittaakos kittaakos commented Jan 10, 2023 •
edited
Loading

Motivation

The Arduino language features must be functional when there is a # in the main sketch file name.

Change description

  • Update the LS version with the fix,
  • Removed an unused module from the code.

Other information

To verify:

  • Your IDE2 installation contains a # in the path. The best is to use something like C:\Users\You\Desktop\# here is your IDE because it will ensure that after cutting the # (fragment) from the URI, it won't try to load VS Code extensions incorrectly from C:\Users\You\Desktop\.
  • You have "arduino.language.realTimeDiagnostics": true, in the settings.json,
  • Create a sketch with a # in the name or your sketchbook path has a #,
  • Select a board,
  • Make syntax errors,
  • You see the error diagnostics in the editor.
  • Create another .ino file and a .cpp lib in the sketch. The Arduino language features must be functional.
1124.mp4
1124.mp4

Closes #1124
Closes #1815

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: language server Related to the Arduino Language Server labels Jan 10, 2023
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Copy link
Contributor Author

kittaakos commented Jan 11, 2023 •
edited
Loading

(削除) It's still failing on Windows: #1124 (comment) (削除ここまで) Fixed ✅

@kittaakos kittaakos marked this pull request as draft January 11, 2023 10:34
Akos Kitta added 2 commits January 11, 2023 17:08 
Closes #1124
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos marked this pull request as ready for review January 11, 2023 16:11
@kittaakos kittaakos force-pushed the #1124 branch 2 times, most recently from 2add0b2 to 107fd9d Compare January 13, 2023 14:18 
Closes #1815
Ref eclipse-theia/theia#12064
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE2 is non-functional when the installation path contains a # "Failed to start language server" error when IDE installation path contains #

AltStyle によって変換されたページ (->オリジナル) /