-
-
Notifications
You must be signed in to change notification settings - Fork 490
chore: Switched to window.zoomLevel preference
#1675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
labels
Nov 14, 2022
3 tasks
AlbyIanna
AlbyIanna
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly for me and code is fine to me 👍
per1234
per1234
approved these changes
Nov 17, 2022
@kittaakos
kittaakos
force-pushed
the
theia-1.31.1
branch
from
November 22, 2022 14:20
7c851ca to
3b8ed7f
Compare
@kittaakos
kittaakos
force-pushed
the
#1657
branch
from
November 23, 2022 13:37
85e85e8 to
f974cfb
Compare
Deprecated `arduino.window.zoomLevel`. Closes #1657 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1657
branch
from
November 29, 2022 08:54
f974cfb to
ee3d392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1662
Motivation
To align the IDE2 codebase with the preferences provided by the Theia framework.
Change description
Breaking
arduino.window.zoomLevelsetting will be ignored. Users have to set the preferred zoom level in one of the following ways:File>Increase Font SizeandFile>Decrease Font Size(assuming that the interface scale is automatic),to readjust the desired scale level.
Alternatively, users can restore the interface scale value via the Adcanced Settings:
Currently, when opening the
settings.jsonin the file, there is a deprecation message for the old settings key:Screen Shot 2022年11月14日 at 17 25 04
window.zoomLevel.mp4
The behavior of the
window.zoomLevelsetting is the same as the deprecatedarduino.window.zoomLevel.This also fixes a bug that triggered saving the
zoomLeveltwice.Other information
Closes #1657
If required, I can remove the deprecation message of the
arduino.window.zoomLevel. Users will see this in thesettings.jsoneditor:Screen Shot 2022年11月14日 at 17 17 00
Reviewer checklist