-
-
Notifications
You must be signed in to change notification settings - Fork 489
fix: escaped regex chars in pattern #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Nov 3, 2022
@kittaakos
kittaakos
force-pushed
the
#1600
branch
from
November 7, 2022 13:29
16b54d5 to
d304922
Compare
per1234
per1234
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes #1600
Thanks Akos!
3 tasks
Closes #1600 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1600
branch
from
November 10, 2022 10:39
d304922 to
88e3de6
Compare
AlbyIanna
AlbyIanna
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
I tested the latest changes (from ~20 mis ago) locally and it works perfectly for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
If regex patterns are not correctly escaped, they will break. Such as the
File>Sketchbookissue when there is a sketch with the following invalid name:bar++.Change description
is-valid-pathcheck. Otherwise, on Windows, it's impossible to open a sketch in the following way:"Arduino IDE.exe" "..\\..\\Documents\\Arduino\\bar++"input will give a false negative result.Other information
Closes #1600
Reviewer checklist