-
-
Notifications
You must be signed in to change notification settings - Fork 489
fix: Handle gracefully when trying to detect invalid sketch name error and folder is missing on filesystem #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Nov 2, 2022
gracefully handle when sketch folder has been deleted Closes #1596 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
The invalid sketch name detection requires at least one extra FS access. Do not try to detect invalid sketch name error, but use the original `NotFound` from the CLI. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1596
branch
from
November 2, 2022 15:38
dfa82d6 to
76a5889
Compare
per1234
per1234
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes #1596 on Windows and Linux.
Thanks Akos!
AlbyIanna
AlbyIanna
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks great to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix missing
Open Recentmenu items in IDE2 when~/arduinoIDE/recent-sketches.jsoncontains non-existing sketches.Change description
The PR consists of three noteworthy changes:
ENOENT(No such file or directory) error when trying to detect if theNotFounderror received from the CLI is an "invalid sketch name" error. See: #964 Prompt move when opening invalid sketch outside from IDE2 #1563 .ErrnoException(errno(3)) detection in IDE2.Open Recentmenus, it does not matter if the missing sketch was deleted or (incorrectly) renamed by the user. Hence the special error detection code does not run.Other information
Closes #1596
Reviewer checklist