-
-
Notifications
You must be signed in to change notification settings - Fork 492
bump arduino-fwuploader to 2.2.2
#1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AlbyIanna
AlbyIanna
requested review from
kittaakos,
davegarthsimpson and
per1234
October 27, 2022 10:39
kittaakos
kittaakos
previously requested changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no newline at the end of file
The version update is OK.
@AlbyIanna
AlbyIanna
force-pushed
the
bump-fwuploader
branch
from
October 27, 2022 12:17
02e8d44 to
c545c7a
Compare
no newline at the end of file
My bad, my editor settings was misconfigured.
I changed it, please review it again.
davegarthsimpson
davegarthsimpson
approved these changes
Oct 27, 2022
@AlbyIanna
AlbyIanna
requested review from
kittaakos
and removed request for
kittaakos
October 27, 2022 12:51
@AlbyIanna
AlbyIanna
dismissed
kittaakos’s stale review
October 27, 2022 12:53
the change has been addressed and approved by Dave
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: infrastructure
Related to project infrastructure
labels
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bump
arduino-fwuploaderto version2.2.2Reviewer checklist